svn commit: r207768 - head/sys/dev/usb/wlan

[Sam Leffler]

On May 11, 2010, at 5:12 AM, Rui Paulo wrote:

> On 8 May 2010, at 12:56, Ed Maste wrote:
>
>> Author: emaste
>> Date: Sat May  8 11:56:00 2010
>> New Revision: 207768
>> URL: http://svn.freebsd.org/changeset/base/207768
>>
>> Log:
>> Add dummy function for ic_update_mcast (a la if_urtw) to avoid  
>> console
>> spam.
>
> I don't agree with this. I think these dummy functions should be  
> removed in all drivers and if the console spam is annoying it should  
> be limited to one message per interface.
>

Yes, I didn't catch the other stubs going in but already talked to Ed  
about this one.  People need to understand that stub'ing out this  
function is masking a real problem.  Drivers that can support mcast  
filtering should do so.  Otherwise we need mcast filtering implemented  
in the 802.3 layer to support the ALLMULTI ifnet flag; in which case  
drivers that are incomplete can fallback on this support.  In lieu of  
working support a better solution is to provide a stub in net80211  
that ratelimits the printf but doesn't completely remove it.

	Sam