svn commit: r205119 - head/contrib/top

Alexander Motin mav at FreeBSD.org
Tue Mar 30 15:34:04 UTC 2010


Bruce Cran wrote:
> Author: brucec
> Date: Sat Mar 13 11:17:39 2010
> New Revision: 205119
> URL: http://svn.freebsd.org/changeset/base/205119
> 
> Log:
>   Change the 'amt' parameter in format_k2 from int to unsigned long long
>   to match the values passed in and prevent the SIZE field being corrupted
>   when more than 2TB is allocated.

This change seems broke top on ARM, as declaration in util.h doesn't
specifies argument type, and caller assumes int there. To make it work
correctly, second part should be done:

--- top.prev/utils.h    2009-10-14 15:23:42.000000000 +0300
+++ top/utils.h 2010-03-30 18:14:11.000000000 +0300
@@ -21,4 +21,4 @@ long percentages();
 char *errmsg();
 char *format_time();
 char *format_k();
-char *format_k2();
+char *format_k2(unsigned long long);

-- 
Alexander Motin


More information about the svn-src-head mailing list