svn commit: r205024 - head/sys/net

Gleb Smirnoff glebius at FreeBSD.org
Fri Mar 12 15:55:22 UTC 2010


On Thu, Mar 11, 2010 at 11:15:21PM -0800, Julian Elischer wrote:
J> Juli Mallett wrote:
J> > On Thu, Mar 11, 2010 at 15:39, Qing Li <qingli at freebsd.org> wrote:
J> >> I guess it's a good time to clean things up. The if_link_state code has been
J> >> around for quite some time, either it be fully utilized or not be there at all.
J> >> The inconsistency is the root cause.
J> > 
J> > Sure.  There is an increasing amount of stuff that network drivers are
J> > expected to do, but they work without doing them.  It's easy to think
J> > you have a functioning network driver and that you can get by without
J> > adding support for media changes and link status reporting, etc.
J> > 
J> >> I will try going through these tonight and hopefully the fix all take a
J> >> common approach.
J> 
J> probably should add a flag that means "we have media state"
J> and if it is not set, assume it is always on.

We've got LINK_STATE_UNKNOWN, we can just initialize if_link_state to
this value in ether_ifattach(). And Qing should treat this value as
LINK_STATE_UP in routing decision until better times.

-- 
Totus tuus, Glebius.


More information about the svn-src-head mailing list