svn commit: r205024 - head/sys/net
qingli at freebsd.org
Fri Mar 12 00:18:38 UTC 2010
> If you can think of a way to add some invariants (warn the first time
> a driver receives a packet without having ever set the link state,
> make sure the media status callback sets the valid flag in the
> request, etc) that would probably be very helpful for people who are
> writing network drivers. If I hadn't been following the threads about
> your changes, I would have had to spend much longer fixing the Octeon
> port's Ethernet driver, wondering why suddenly it broke and
> instrumenting the routing code. A printf would go a long way.
You definitely have a very good point here. I was a bit surprised
during debugging that the link state is not consistently initialized
and by far not enforced across all of the drivers. Admittedly I checked
the most commonly deployed devices and they are in good state.
I certainly appreciate your patience on this one and will try to get
it resolved quickly.
More information about the svn-src-head