svn commit: r204974 - head/lib/libc/sparc64/fpu

Peter Jeremy peterjeremy at acm.org
Wed Mar 10 23:46:30 UTC 2010


One bug that crept in somewhere:

On 2010-Mar-10 19:55:48 +0000, Marius Strobl <marius at FreeBSD.org> wrote:
>Modified: head/lib/libc/sparc64/fpu/fpu.c
>@@ -181,15 +182,11 @@ __fpu_dumpfpn(struct fpn *fp)
> }
> #endif
> 
>-static int opmask[] = {0, 0, 1, 3};
>+static const int opmask[] = {0, 0, 1, 3, 1};
> 
...
>Modified: head/lib/libc/sparc64/fpu/fpu_emu.h
>==============================================================================
>--- head/lib/libc/sparc64/fpu/fpu_emu.h	Wed Mar 10 19:55:27 2010	(r204973)
>+++ head/lib/libc/sparc64/fpu/fpu_emu.h	Wed Mar 10 19:55:48 2010	(r204974)
>@@ -140,7 +140,7 @@ struct fpn {
> #define	FTYPE_SNG	INSFP_s
> #define	FTYPE_DBL	INSFP_d
> #define	FTYPE_EXT	INSFP_q
>-#define	FTYPE_LNG	-1
>+#define	FTYPE_LNG	5

FTYPE_* are used as indexes into opmask[].  Somewhere along the line,
FTYPE_LNG has changed from 4 to 5 but the opmask[] initialisers still
assume 4.  (It might be worth adding a comment into opmask[] so this
relationship is noted in future).

-- 
Peter Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20100310/84b53b12/attachment.pgp


More information about the svn-src-head mailing list