svn commit: r204840 - head/sbin/mount
Bjoern A. Zeeb
bz at FreeBSD.org
Sun Mar 7 16:45:19 UTC 2010
Author: bz
Date: Sun Mar 7 16:45:18 2010
New Revision: 204840
URL: http://svn.freebsd.org/changeset/base/204840
Log:
As statfs.f_flags are uint64_t the local variables should be as well.
We'll start noticing this with the next flag introduced as the lower
32bit are all used.
As this is old code we might need to do a full tree sweep one day, unless
changing our strategy to use a different `API' for getting/setting flags
along with the rest of the statfs data.
While here compare to 0 explicitly [1].
Suggested by: kib [1]
Reviewed by: kib
MFC after: 5 days
Modified:
head/sbin/mount/mount.c
Modified: head/sbin/mount/mount.c
==============================================================================
--- head/sbin/mount/mount.c Sun Mar 7 16:24:33 2010 (r204839)
+++ head/sbin/mount/mount.c Sun Mar 7 16:45:18 2010 (r204840)
@@ -91,7 +91,7 @@ char *flags2opts(int);
/* Map from mount options to printable formats. */
static struct opt {
- int o_opt;
+ uint64_t o_opt;
const char *o_name;
} optnames[] = {
{ MNT_ASYNC, "asynchronous" },
@@ -612,7 +612,7 @@ mountfs(const char *vfstype, const char
void
prmount(struct statfs *sfp)
{
- int flags;
+ uint64_t flags;
unsigned int i;
struct opt *o;
struct passwd *pw;
@@ -621,7 +621,7 @@ prmount(struct statfs *sfp)
sfp->f_fstypename);
flags = sfp->f_flags & MNT_VISFLAGMASK;
- for (o = optnames; flags && o->o_opt; o++)
+ for (o = optnames; flags != 0 && o->o_opt != 0; o++)
if (flags & o->o_opt) {
(void)printf(", %s", o->o_name);
flags &= ~o->o_opt;
More information about the svn-src-head
mailing list