svn commit: r194266 - head/usr.bin/chpass

[M. Warner Losh]

In message: <DA308DE7-889E-4742-A703-62F245B808EF at samsco.org>
            Scott Long <scottl at samsco.org> writes:
: On Mar 4, 2010, at 11:53 AM, M. Warner Losh wrote:
: > In message: <9A8644AD-3B92-4BCE-8A51-132F8EA35F7D at samsco.org>
: >            Scott Long <scottl at samsco.org> writes:
: > : On Mar 4, 2010, at 10:53 AM, M. Warner Losh wrote:
: > : > 
: > : > In message: <CADA450C-C67C-47DA-BF64-40FFE011B1E9 at samsco.org>
: > : >            Scott Long <scottl at samsco.org> writes:
: > : > : Forcing the entire build to fail if chflags fails breaks installing
: > : > : to an NFS destination.  I haven't tested all possible permutations
: > : > : of src vs dest filesystems mounting, but I don't see how it can
: > : > : work over any type of NFS mount.  What is the reason for forcing
: > : > : this failure?  The NO_FSCHG variable is undocumented, and the
: > : > : failure mode here is pretty useless at helping the user fix the
: > : > : problem.  I'd like to re-add the '-' modifier to the chflags
: > : > : command that you removed.
: > : > 
: > : > NO_FSCHG variable has been around a long time, and is de-facto
: > : > supported.  It will be documented shortly when I get done cleaning up
: > : > build(7).
: > : > 
: > : > NO_FSCHG has been the documented way (in examples) for installing over
: > : > NFS for a very long time.  It looks to my eye like this change fixed a
: > : > problem with that...
: > : > 
: > : > Warner
: > : > 
: > : > : 
: > : 
: > : Every other base package that sets schg does so by allowing chflags to silently fail.  My change puts chpass back into conformance with the status quo.
: > 
: > Well, maybe for chflags, but not for install.  You still need NO_FSCHG
: > if you are installing over NFS, with or without this change...
: > 
: 
: What am I missing by not using it?  Just a few minutes ago I did a successful install over NFS on 9-current and 7-stable.

Last night it failed for me when installing libraries....  Part of the
problem was that they had been installed with schg when I'd built the
tree on the local machine rather than my new remote machine...

But it looks like this morning when I tried it to cut-and-paste the
error, I can't find it with the -chflags change you made.

So it looks like the need for flag for nfs installs has passed...

Warner