svn commit: r209119 - head/sys/sys

[Gabor Kovesdan]

>>
>> +/*
>> + * Utility macros.
>> + */
>> +#define DPCPU_SUM(n, var, sum)						\
>> +do {									\
>> +	(sum) = 0;							\
>> +	u_int i;							\
>> +	CPU_FOREACH(i)							\
>> +		(sum) += (DPCPU_ID_PTR(i, n))->var;			\
>> +} while (0)
>>      
> I'd suggest first swapping variable declaration and '(sum) = 0;'.
> Also using 'i' as a counter in macro can easly lead to name collision.
> If you need to do it, I'd suggest '_i' or something.
> Maybe it would be better to make it an inline function rather than macro?
>    
And why using old BSD-stlye u_int? style(9) also suggest using ISO C types.

-- 
Gabor Kovesdan
FreeBSD Volunteer

EMAIL: gabor at FreeBSD.org .:|:. gabor at kovesdan.org
WEB:   http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org