svn commit: r208781 - head/sys/kern

Edward Tomasz Napierala trasz at FreeBSD.org
Thu Jun 3 13:45:28 UTC 2010


Author: trasz
Date: Thu Jun  3 13:45:27 2010
New Revision: 208781
URL: http://svn.freebsd.org/changeset/base/208781

Log:
  The 'acl_cnt' field is unsigned; no point in checking if it's >= 0.
  
  Found with:	Coverity Prevent
  CID:		3688

Modified:
  head/sys/kern/vfs_acl.c

Modified: head/sys/kern/vfs_acl.c
==============================================================================
--- head/sys/kern/vfs_acl.c	Thu Jun  3 13:43:58 2010	(r208780)
+++ head/sys/kern/vfs_acl.c	Thu Jun  3 13:45:27 2010	(r208781)
@@ -92,7 +92,7 @@ acl_copy_acl_into_oldacl(const struct ac
 {
 	int i;
 
-	if (source->acl_cnt < 0 || source->acl_cnt > OLDACL_MAX_ENTRIES)
+	if (source->acl_cnt > OLDACL_MAX_ENTRIES)
 		return (EINVAL);
 
 	bzero(dest, sizeof(*dest));


More information about the svn-src-head mailing list