svn commit: r210451 - head/sys/sys
Stefan Farfeleder
stefanf at FreeBSD.org
Sat Jul 24 18:37:38 UTC 2010
Hi Konstantin,
declaring enums like this is not standard C code (seems to be a GCC
extension). I don't think we should use this feature in our headers.
Stefan
On Sat, Jul 24, 2010 at 06:14:34PM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Sat Jul 24 18:14:34 2010
> New Revision: 210451
> URL: http://svn.freebsd.org/changeset/base/210451
>
> Log:
> Use forward declartion for enum uio_seg in imgact.h. This allows to remove
> inclusion of sys/uio.h from the header.
>
> Proposed by: alc
> MFC after: 1 week
>
> Modified:
> head/sys/sys/imgact.h
>
> Modified: head/sys/sys/imgact.h
> ==============================================================================
> --- head/sys/sys/imgact.h Sat Jul 24 18:05:10 2010 (r210450)
> +++ head/sys/sys/imgact.h Sat Jul 24 18:14:34 2010 (r210451)
> @@ -32,8 +32,6 @@
> #ifndef _SYS_IMGACT_H_
> #define _SYS_IMGACT_H_
>
> -#include <sys/uio.h>
> -
> #define MAXSHELLCMDLEN PAGE_SIZE
>
> struct image_args {
> @@ -75,6 +73,7 @@ struct image_params {
> #ifdef _KERNEL
> struct sysentvec;
> struct thread;
> +enum uio_seg;
>
> #define IMGACT_CORE_COMPRESS 0x01
>
>
More information about the svn-src-head
mailing list