svn commit: r210005 - head/sys/modules/acpi/acpi

[M. Warner Losh]

In message: <201007161514.04955.jkim at FreeBSD.org>
            Jung-uk Kim <jkim at FreeBSD.org> writes:
: On Thursday 15 July 2010 08:04 am, Bruce Evans wrote:
: > On Tue, 13 Jul 2010, Jung-uk Kim wrote:
: > > Log:
: > >  Define SMP unconditionally for amd64 and remove opt_global.h
: > > from SRCS. Note it is done just for correctness sake because we
: > > do not build, ship, or support acpi.ko on amd64.
: > >
: > >  Prodded by:	bde
: >
: > Thanks.
: >
: > It was much more interesting than I noticed.  Modules are supposed
: > to be independent of all configuration options, especially global
: > ones, especially especially SMP.  Perhaps this is too much to ask
: > for acpi. Does it work now, after you removed an SMP ifdef from it?
: 
: I removed "#ifdef SMP" from acpi.c because 'smp_started' is available 
: for both UP and SMP kernels.  On the other hand, I cannot remove 
: these easily from sys/amd64/acpica/acpi_wakeup.c, i.e., it requires 
: some symbols from sys/amd64/amd64/mp_machdep.c, which are only 
: available in SMP case.
: 
: FYI, we never had to worry about acpi.ko on i386 because we didn't 
: implement suspend/resume for SMP case in the first place. X-)

Does this mean we do implement it on amd64 now?  I may have to start
trying to use it again...

Warner