svn commit: r210138 - in head/sys: kern sys

[Bjoern A. Zeeb]

On Fri, 16 Jul 2010, Kostik Belousov wrote:

> On Fri, Jul 16, 2010 at 06:44:39AM +0000, Bjoern A. Zeeb wrote:
>> On Thu, 15 Jul 2010, John Baldwin wrote:
>>
>>> Author: jhb
>>> Date: Thu Jul 15 20:24:37 2010
>>> New Revision: 210138
>>> URL: http://svn.freebsd.org/changeset/base/210138
>>>
>>> Log:
>>> Retire td_syscalls now that it is no longer needed.
>>>
>>> Modified:
>>> head/sys/kern/kern_thread.c
>>> head/sys/kern/subr_trap.c
>>> head/sys/sys/proc.h
>>
>> Did you want to leave the field as a placehgolder or add a note
>> somewhere that people should do a full recompile because the layout
>> changed?
> Make depend should do the magic, right ?

right, I am more worried about (out of tree) modules.  struct thread
is basically everywhere with curthread and thread * passed around and
modules will not refuse to load as freebsd_version hasn't changed.

> I was surprised to see that mips/arm did not touched td_syscalls, and
> I wonder how much other bugs are lurking in their implementation.
>>
>>
>>> Modified: head/sys/sys/proc.h
>>> ==============================================================================
>>> --- head/sys/sys/proc.h	Thu Jul 15 19:52:54 2010	(r210137)
>>> +++ head/sys/sys/proc.h	Thu Jul 15 20:24:37 2010	(r210138)
>>> @@ -296,7 +296,6 @@ struct thread {
>>> 	struct mdthread td_md;		/* (k) Any machine-dependent fields.
>>> 	*/
>>> 	struct td_sched	*td_sched;	/* (*) Scheduler-specific data. */
>>> 	struct kaudit_record	*td_ar;	/* (k) Active audit record, if any.
>>> 	*/
>>> -	int		td_syscalls;	/* per-thread syscall count (used by
>>> NFS :)) */
>>> 	struct lpohead	td_lprof[2];	/* (a) lock profiling objects. */
>>> 	struct kdtrace_thread	*td_dtrace; /* (*) DTrace-specific data. */
>>> 	int		td_errno;	/* Error returned by last syscall. */
>>>
>>
>> --
>> Bjoern A. Zeeb    From August on I will have a life.  It's now up to you
>> to do the maths and count to 64.     -- Bondorf, Germany, 14th June 2010
>

-- 
Bjoern A. Zeeb    From August on I will have a life.  It's now up to you
to do the maths and count to 64.     -- Bondorf, Germany, 14th June 2010