svn commit: r202821 - head/sys/dev/bge

Pyun YongHyeon yongari at FreeBSD.org
Fri Jan 22 18:35:50 UTC 2010


Author: yongari
Date: Fri Jan 22 18:35:50 2010
New Revision: 202821
URL: http://svn.freebsd.org/changeset/base/202821

Log:
  Fix a long standing ASF heartbeat sending bug. The initial
  implementation of heartbeat interval was 2 but there was typo which
  caused the heartbeat is sent approximately every 5 seconds. This
  caused unintended controller reset by firmware because firmware
  thought OS was crashed.
  
  Submitted by:	Floris Bos < info <> je-eigen-domein dot nl >
  Tested by:	Andrzej Tobola < ato <> iem dot pw dot edu dot pl >

Modified:
  head/sys/dev/bge/if_bge.c

Modified: head/sys/dev/bge/if_bge.c
==============================================================================
--- head/sys/dev/bge/if_bge.c	Fri Jan 22 17:33:04 2010	(r202820)
+++ head/sys/dev/bge/if_bge.c	Fri Jan 22 18:35:50 2010	(r202821)
@@ -3677,7 +3677,7 @@ bge_asf_driver_up(struct bge_softc *sc)
 		if (sc->bge_asf_count)
 			sc->bge_asf_count --;
 		else {
-			sc->bge_asf_count = 5;
+			sc->bge_asf_count = 2;
 			bge_writemem_ind(sc, BGE_SOFTWARE_GENCOMM_FW,
 			    BGE_FW_DRV_ALIVE);
 			bge_writemem_ind(sc, BGE_SOFTWARE_GENNCOMM_FW_LEN, 4);


More information about the svn-src-head mailing list