svn commit: r202778 - head/lib/libc/gen
Ed Schouten
ed at FreeBSD.org
Fri Jan 22 04:53:09 UTC 2010
Author: ed
Date: Fri Jan 22 04:53:08 2010
New Revision: 202778
URL: http://svn.freebsd.org/changeset/base/202778
Log:
Remove comments about breaking the specification.
I've discussed this issue with the Austin Group and it will be fixed in
future revisions of the specification. The issue was that ut_line fields
weren't supposed to be valid for LOGIN_PROCESS entries, while
getutxline() would try to match these records anyway.
They also agreed on our way of implementing pututxline() without
getutxid() (which other operating systems also do), but unfortunately
they disagreed with our way of replacing DEAD_PROCESS entries, which is
a pity. The current specification allows the utmpx database to become
infinitely big over time.
See also: http://austingroupbugs.net/view.php?id=213#c378
Modified:
head/lib/libc/gen/utxdb.c
Modified: head/lib/libc/gen/utxdb.c
==============================================================================
--- head/lib/libc/gen/utxdb.c Fri Jan 22 03:59:05 2010 (r202777)
+++ head/lib/libc/gen/utxdb.c Fri Jan 22 04:53:08 2010 (r202778)
@@ -83,7 +83,6 @@ utx_to_futx(const struct utmpx *ut, stru
case LOGIN_PROCESS:
UTOF_ID(ut, fu);
UTOF_STRING(ut, fu, user);
- /* XXX: bug in the specification? Needed for getutxline(). */
UTOF_STRING(ut, fu, line);
UTOF_PID(ut, fu);
break;
@@ -156,7 +155,6 @@ futx_to_utx(const struct futx *fu)
case LOGIN_PROCESS:
FTOU_ID(fu, ut);
FTOU_STRING(fu, ut, user);
- /* XXX: bug in the specification? Needed for getutxline(). */
FTOU_STRING(fu, ut, line);
FTOU_PID(fu, ut);
break;
More information about the svn-src-head
mailing list