svn commit: r202185 - head/lib/libc/gen

David Xu davidxu at FreeBSD.org
Wed Jan 13 08:53:23 UTC 2010


Author: davidxu
Date: Wed Jan 13 08:53:23 2010
New Revision: 202185
URL: http://svn.freebsd.org/changeset/base/202185

Log:
  Return SEM_FAILED instead of NULL, though there are same, but the
  SEM_FAILED is more suitable name.
  In function, sem_close(), always set errno on error.

Modified:
  head/lib/libc/gen/sem_new.c

Modified: head/lib/libc/gen/sem_new.c
==============================================================================
--- head/lib/libc/gen/sem_new.c	Wed Jan 13 08:21:19 2010	(r202184)
+++ head/lib/libc/gen/sem_new.c	Wed Jan 13 08:53:23 2010	(r202185)
@@ -147,13 +147,13 @@ _sem_open(const char *name, int flags, .
 
 	if (name[0] != '/') {
 		errno = EINVAL;
-		return (NULL);
+		return (SEM_FAILED);
 	}
 	name++;
 
 	if (flags & ~(O_CREAT|O_EXCL)) {
 		errno = EINVAL;
-		return (NULL);
+		return (SEM_FAILED);
 	}
 
 	_pthread_once(&once, sem_module_init);
@@ -275,6 +275,7 @@ _sem_close(sem_t *sem)
 		return (0);
 	}
 	_pthread_mutex_unlock(&sem_llock);
+	errno = EINVAL;
 	return (-1);
 }
 


More information about the svn-src-head mailing list