svn commit: r206419 - head/sys/net80211
Rui Paulo
rpaulo at FreeBSD.org
Mon Apr 12 14:33:58 UTC 2010
On 11 Apr 2010, at 23:44, Sam Leffler wrote:
> Rui Paulo wrote:
>> Author: rpaulo
>> Date: Fri Apr 9 12:06:19 2010
>> New Revision: 206419
>> URL: http://svn.freebsd.org/changeset/base/206419
>> Log:
>> Use M_NOWAIT instead of M_WAITOK to avoid race conditions.
>>
>
> Can you describe these race conditions (or at least one of them)?
Some drivers call ratectl functions with locks held. I saw similar allocations in the net80211 stack that used M_NOWAIT and printed an error if the allocation failed, but didn't notify the caller (for example ieee80211_node_table_init()).
If I use M_WAITOK here I'll also get WITNESS warnings.
Regards,
--
Rui Paulo
More information about the svn-src-head
mailing list