svn commit: r189625 - head/sys/geom/eli

[Guido van Rooij]

On Tue, Mar 10, 2009 at 05:19:48PM +0100, Fabian Keil wrote:
> > Log:
> >   When attaching a geli on boot make sure that it is detached
> >   upon last close. (needed for a gmirror to properly shutdown
> >   upon reboot when a geli is on top the gmirror)
> > 
> 
> Detach-on-last-close is known to cause panics when
> scrubbing at least some ZFS pools:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/117158
> 
> Quoting the PR:
> |Quoting Pawel Jakub Dawidek's response to my initial report:
> ||GELI's detach-on-last-close mechanism is a general purpose mechanism, it
> ||may not work correctly with ZFS, because ZFS sometimes closes and reopen
> ||providers, which will make GELI to detach. In other words you shouldn't
> ||configure detach-on-last-close for ZFS components. 
> 

Grr. So we should make it tuneable. How about being able to set
this flag with the geli command, like the G_ELI_FLAG_BOOT flag.

-Guido