svn commit: r195436 - in head/sys: dev/ata geom geom/part sys

Poul-Henning Kamp phk at
Wed Jul 8 08:16:31 UTC 2009

In message <200907080556.n685uFsn040044 at>, Marcel Moolenaar writ

>  Revert revisions 188839 and 188868. Use of the ioctl in geom_dev.c
>  is invalid because the ioctl happens without prior open. The ioctl
>  got introduced to provide backward compatibility for extended
>  partitions, but it ended up not being used because it didn't work
>  as expected. Since there are no consumers of the ioctl and the
>  implementation is broken, the best fix is to remove the code
>  entirely.
>  Spotted by:	phk

For the record
	Really spotted by:	scottl

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the svn-src-head mailing list