svn commit: r187374 - head/sys/dev/syscons/teken

[Christoph Mallon]

Garrett Cooper schrieb:
> On Sat, Jan 17, 2009 at 3:01 PM, Ed Schouten <ed at freebsd.org> wrote:
> 
> [...]
> 
>> Modified:
>>  head/sys/dev/syscons/teken/teken_subr_compat.h
>>
>> Modified: head/sys/dev/syscons/teken/teken_subr_compat.h
>> ==============================================================================
>> --- head/sys/dev/syscons/teken/teken_subr_compat.h      Sat Jan 17 22:53:53 2009        (r187373)
>> +++ head/sys/dev/syscons/teken/teken_subr_compat.h      Sat Jan 17 23:01:40 2009        (r187374)
>> @@ -33,20 +33,23 @@ teken_subr_cons25_set_cursor_type(teken_
>>        teken_funcs_param(t, TP_SHOWCURSOR, type != 1);
>>  }
> 
> [...]
> 
> Dumb question:
> 
> Why are C function definitions in a .h file? I know it's legal, but at
> least from what I've been coached on in the past, it isn't necessarily
> the most kosher way of solving the issue.
> 
> Macros are a different point.

This is just a one-time include. I guess Ed used the .h suffix so his 
$EDITOR chooses the right syntax highlighting. There is some magic going 
on to call these functions (you probably noticed he didn't add any 
obvious callers): The callers are generated by a script. The differnt 
parts are then all included in teken.c.