svn commit: r187251 - head/sys/mips/malta
Alexey Dokuchaev
danfe at FreeBSD.org
Thu Jan 15 03:44:08 PST 2009
On Wed, Jan 14, 2009 at 07:05:27PM -0700, M. Warner Losh wrote:
> In message: <20090115020752.52566769.stas at FreeBSD.org>
> Stanislav Sedov <stas at FreeBSD.org> writes:
> : > + shift = 8 * (reg & 3);
> : >
> :
> : Would it make sense to replace this with
> : > + shift = (reg & 3) << 3;
> :
> : to not rely on possible compiler optimizations?
>
> I don't think that it matters all that much these days...
But the name "shift" kinda suggests << instead of *, no?
./danfe
More information about the svn-src-head
mailing list