svn commit: r186907 - head/sys/netgraph

Alexander Motin mav at FreeBSD.org
Thu Jan 8 09:51:17 PST 2009


Author: mav
Date: Thu Jan  8 17:51:15 2009
New Revision: 186907
URL: http://svn.freebsd.org/changeset/base/186907

Log:
  Mark ng_vjc node as FORCE_WRITER to protect slcompress state.
  I think it can be the reason of livelock in netgraph reported by some
  mpd users.
  
  MFC after:	3 days

Modified:
  head/sys/netgraph/ng_vjc.c

Modified: head/sys/netgraph/ng_vjc.c
==============================================================================
--- head/sys/netgraph/ng_vjc.c	Thu Jan  8 17:47:45 2009	(r186906)
+++ head/sys/netgraph/ng_vjc.c	Thu Jan  8 17:51:15 2009	(r186907)
@@ -249,6 +249,9 @@ ng_vjc_constructor(node_p node)
 
 	NG_NODE_SET_PRIVATE(node, priv);
 
+	/* slcompress is not thread-safe. Protect it's state here. */
+	NG_NODE_FORCE_WRITER(node);
+
 	/* Done */
 	return (0);
 }


More information about the svn-src-head mailing list