svn commit: r188457 - head/sys/dev/bge

[Coleman Kane]

On Tue, 2009-02-10 at 21:54 +0000, Marius Strobl wrote:
> Author: marius
> Date: Tue Feb 10 21:54:23 2009
> New Revision: 188457
> URL: http://svn.freebsd.org/changeset/base/188457
> 
> Log:
>   Don't reset the PHY probe retry counter within the loop so
>   it will eventually terminate as intended.
>   
>   Submitted by:	Helen Zhang
> 
> Modified:
>   head/sys/dev/bge/if_bge.c
> 
> Modified: head/sys/dev/bge/if_bge.c
> ==============================================================================
> --- head/sys/dev/bge/if_bge.c	Tue Feb 10 21:51:33 2009	(r188456)
> +++ head/sys/dev/bge/if_bge.c	Tue Feb 10 21:54:23 2009	(r188457)
> @@ -2674,11 +2674,11 @@ bge_attach(device_t dev)
>  		 * if we get a conflict with the ASF firmware accessing
>  		 * the PHY.
>  		 */
> +		trys = 0;
>  		BGE_CLRBIT(sc, BGE_MODE_CTL, BGE_MODECTL_STACKUP);
>  again:
>  		bge_asf_driver_up(sc);
>  
> -		trys = 0;
>  		if (mii_phy_probe(dev, &sc->bge_miibus,
>  		    bge_ifmedia_upd, bge_ifmedia_sts)) {
>  			if (trys++ < 4) {
> 

I'm curious... I recent ran into a problem where this driver was not
properly recovering from an ACPI resume event (under amd64 with some
patches). I am curious if this patch might fix that problem... as the
death happened somewhere around here.

What example case did you use to discover this bug?

-- 
Coleman Kane
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20090210/b3c353fb/attachment.pgp