svn commit: r188154 - head/sys/opencrypto

[M. Warner Losh]

In message: <498B2829.9000608 at gmail.com>
            Niclas Zeising <niclas.zeising at gmail.com> writes:
: Warner Losh wrote:
: > Author: imp
: > Date: Thu Feb  5 17:43:12 2009
: > New Revision: 188154
: > URL: http://svn.freebsd.org/changeset/base/188154
: > 
: > Log:
: >   Fix return type for detach routine (should be int)
: >   Fix first parameter for identify routine (should be driver_t *)
: > 
: > Modified:
: >   head/sys/opencrypto/cryptosoft.c
: > 
: > Modified: head/sys/opencrypto/cryptosoft.c
: > ==============================================================================
: > --- head/sys/opencrypto/cryptosoft.c	Thu Feb  5 15:09:42 2009	(r188153)
: > +++ head/sys/opencrypto/cryptosoft.c	Thu Feb  5 17:43:12 2009	(r188154)
: > @@ -986,7 +986,7 @@ done:
: >  }
: >  
: >  static void
: > -swcr_identify(device_t *dev, device_t parent)
: > +swcr_identify(driver_t *drv, device_t parent)
:                             ^^^
: 
: Was this name change intentional?

Yes.  It 'dev' is typically used for 'device_t' types.  However, by
changing this to drv, it shows it isn't a device_t, and also breaks
any code that used the old variable with a compiler error.

Warner

: >  {
: >  	/* NB: order 10 is so we get attached after h/w devices */
: >  	if (device_find_child(parent, "cryptosoft", -1) == NULL &&
: > @@ -1040,12 +1040,13 @@ swcr_attach(device_t dev)
: >  	return 0;
: >  }
: >  
: > -static void
: > +static int
: >  swcr_detach(device_t dev)
: >  {
: >  	crypto_unregister_all(swcr_id);
: >  	if (swcr_sessions != NULL)
: >  		free(swcr_sessions, M_CRYPTO_DATA);
: > +	return 0;
: >  }
: >  
: >  static device_method_t swcr_methods[] = {
: 
: Regards!
: //Niclas
: 
: