svn commit: r200998 - in head: bin/sh tools/regression/bin/sh/builtins

[Jilles Tjoelker]

Author: jilles
Date: Fri Dec 25 20:21:35 2009
New Revision: 200998
URL: http://svn.freebsd.org/changeset/base/200998

Log:
  sh: Do not run callers' exception handlers in subshells.
  
  Reset the exception handler in the child to main's.
  
  This avoids inappropriate double cleanups or shell duplication when the
  exception is caught, such as 'fc' and future 'command eval' and 'command .'.

Added:
  head/tools/regression/bin/sh/builtins/fc2.0   (contents, props changed)
Modified:
  head/bin/sh/jobs.c
  head/bin/sh/main.c
  head/bin/sh/main.h

Modified: head/bin/sh/jobs.c
==============================================================================
--- head/bin/sh/jobs.c	Fri Dec 25 20:07:48 2009	(r200997)
+++ head/bin/sh/jobs.c	Fri Dec 25 20:21:35 2009	(r200998)
@@ -757,6 +757,7 @@ forkshell(struct job *jp, union node *n,
 		TRACE(("Child shell %d\n", (int)getpid()));
 		wasroot = rootshell;
 		rootshell = 0;
+		handler = &main_handler;
 		closescript();
 		INTON;
 		clear_traps();

Modified: head/bin/sh/main.c
==============================================================================
--- head/bin/sh/main.c	Fri Dec 25 20:07:48 2009	(r200997)
+++ head/bin/sh/main.c	Fri Dec 25 20:21:35 2009	(r200998)
@@ -75,6 +75,7 @@ __FBSDID("$FreeBSD$");
 
 int rootpid;
 int rootshell;
+struct jmploc main_handler;
 
 STATIC void read_profile(char *);
 STATIC char *find_dot_file(char *);
@@ -90,14 +91,13 @@ STATIC char *find_dot_file(char *);
 int
 main(int argc, char *argv[])
 {
-	struct jmploc jmploc;
 	struct stackmark smark;
 	volatile int state;
 	char *shinit;
 
 	(void) setlocale(LC_ALL, "");
 	state = 0;
-	if (setjmp(jmploc.loc)) {
+	if (setjmp(main_handler.loc)) {
 		/*
 		 * When a shell procedure is executed, we raise the
 		 * exception EXSHELLPROC to clean up before executing
@@ -143,7 +143,7 @@ main(int argc, char *argv[])
 		else
 			goto state4;
 	}
-	handler = &jmploc;
+	handler = &main_handler;
 #ifdef DEBUG
 	opentrace();
 	trputs("Shell args:  ");  trargs(argv);

Modified: head/bin/sh/main.h
==============================================================================
--- head/bin/sh/main.h	Fri Dec 25 20:07:48 2009	(r200997)
+++ head/bin/sh/main.h	Fri Dec 25 20:21:35 2009	(r200998)
@@ -35,6 +35,7 @@
 
 extern int rootpid;	/* pid of main shell */
 extern int rootshell;	/* true if we aren't a child of the main shell */
+extern struct jmploc main_handler;	/* top level exception handler */
 
 void readcmdfile(const char *);
 void cmdloop(int);

Added: head/tools/regression/bin/sh/builtins/fc2.0
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/tools/regression/bin/sh/builtins/fc2.0	Fri Dec 25 20:21:35 2009	(r200998)
@@ -0,0 +1,34 @@
+# $FreeBSD$
+set -e
+trap 'echo Broken pipe -- test failed' pipe
+
+P=${TMPDIR:-/tmp}
+cd $P
+T=$(mktemp -d sh-test.XXXXXX)
+cd $T
+
+mkfifo input output error
+HISTFILE=/dev/null sh +m -i <input >output 2>error &
+exec 3>input
+{
+	# Command not found, containing slash
+	echo '/var/empty/nonexistent' >&3
+	# Read error message, shell will read new input now
+	read dummy <&5
+	# Execute bad command again
+	echo 'fc -e true; echo continued' >&3
+	read dummy <&5
+	read line <&4 && [ "$line" = continued ] && : ${rc:=0}
+	exec 3>&-
+	# Old sh duplicates itself after the fc, producing another line
+	# of output.
+	if read line <&4; then
+		echo "Extraneous output: $line"
+		rc=1
+	fi
+} 4<output 5<error
+exec 3>&-
+
+rm input output error
+rmdir ${P}/${T}
+exit ${rc:-3}