svn commit: r200732 - in head/sys: fs/devfs kern sys
ed at 80386.nl
Sat Dec 19 19:01:53 UTC 2009
* Kostik Belousov <kostikbel at gmail.com> wrote:
> Note that struct devfs_dirent is available as vp->v_data, and
> devfs_dirent' de_cdp member contains pointer to cdev_priv. I think this
> would allow to remove s_ttydp.
Well, there are lots of fields that could be derived. We could even
remove s_ttyp and only use the vnode, because cdp_c.si_drv1 contains a
pointer to the TTY.
The reason why I didn't choose that approach, was because I'm a bit
afraid we get these insanely long chains of pointer dereferences, of
which I'm not entirely sure we do the locking properly. Even right now
I'm not sure whether we pick up proctree_lock enough. s_ttydp isn't too
strict about any form of locking, because its value is only used
Ed Schouten <ed at 80386.nl>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20091219/f92e9b6b/attachment.pgp
More information about the svn-src-head