svn commit: r195960 - in head/sys/dev/usb: . controller input

Navdeep Parhar np at FreeBSD.org
Tue Aug 4 03:14:07 UTC 2009


On Mon, Aug 03, 2009 at 08:33:04PM +0200, Hans Petter Selasky wrote:
> On Monday 03 August 2009 19:46:16 Bruce Evans wrote:
> > On Mon, 3 Aug 2009, M. Warner Losh wrote:
> > > In message: <200908030827.21108.hselasky at c2i.net>
> > >
> > > : I see two solutions:
> > > :
> > > : 1) Disable the timekeeping if no keys are pressed.
> > > :
> > > : 2) Second option is to use getmicrotime. Actually what I need is just a
> > > : millisecond time reference so I know when to repeat the last key.
> > > :
> > > : Any opinions? DELAY() or getmicrotime() ?
> >
> > DELAY(1) is somewhet usable.
> 
> I think DELAY(1) is not accurate enough.
> 
> I suggest that the DELAY(1000) is only active while a key is actually pressed.
> 
> See attached patch. Please test and report back.

This patch fixes my problem.  The machine is remote and I'm unable
to test whether the USB keyboard and keystroke repetition works, but
core dumps to a SATA disk are now as fast as they were before
r195960.  Thanks.

Regards,
Navdeep


More information about the svn-src-head mailing list