svn commit: r191330 - head/usr.bin/ncal
das at FreeBSD.ORG
Tue Apr 21 19:43:09 UTC 2009
On Tue, Apr 21, 2009, Roman Divacky wrote:
> > Also, before this change, ncal was already full of convoluted
> > buffer handling, arbitrary buffer sizes, and little to no bounds
> > checking. This commit adds more magic numbers and fragile buffer
> > handling code, and generally makes an already hairy program even
> > less scrutable. This isn't your fault, but it would be nice if we
> > could make ncal better before it gets much worse. For instance,
> > you might use snprintf() or asprintf() instead of an extra half
> > dozen calls to memcpy() with various offsets.
> yes, thats true. do you want me to revert this? I am perfectly fine
> with having locally modified cal that supports this highlighting
> and not share this with world at all.
I don't care (although some other people on this thread seem to);
I'm just encouraging you to clean things up a little before making
the code even less maintainable.
More information about the svn-src-head