svn commit: r184194 - in head/sys: conf mips/conf

[Warner Losh]

From: Marcel Moolenaar <xcllnt at mac.com>
Subject: Re: svn commit: r184194 - in head/sys: conf mips/conf
Date: Fri, 24 Oct 2008 09:04:32 -0700

> 
> On Oct 24, 2008, at 1:50 AM, Bruce M. Simpson wrote:
> 
> > Warner Losh wrote:
> >>>  Add mips/conf/DEFAULTS and populate it with:
> >>>          machine arm
> >>>          device  mem
> >>>  	device  uart_ns8250
> >>>          options GEOM_BSD
> >>>          options GEOM_MBR
> >>>    Remove the first three from all kernel configuration files
> >>>  (sometimes commented-out) and change geom_bsd and geom_mbr
> >>>  from standard to optional.
> >>>
> >>
> >> We shouldn't be using DEFAULTS for this.
> >>
> >
> > I agree. Marcel, can you please back this change out (at least the  
> > mips or SENTRY5 part of it) ?
> >
> > uart support isn't ready on SENTRY5; shipping these drivers in a  
> > default configuration just adds dead wood on a platform where kernel  
> > size is critical.
> 
> I have no problem reverting, but the reasons you put forward
> don't hold. uart(4) is not enabled by default so there's no
> change to the SENTRY5 configuration at all in that respect.
> Please provide other grounds for reversal.

(1) You didn't ask us first.
(2) Others have said this is a bad idea.
(3) There's appears to be a conensus that we should move the other way
    from what you are doing.

Warner