svn commit: r184161 - head/sys/i386/i386

[Jung-uk Kim]

On Wednesday 22 October 2008 11:04 am, Kostik Belousov wrote:
> On Wed, Oct 22, 2008 at 02:45:30PM +0000, Andrey A. Chernov wrote:
> > Author: ache
> > Date: Wed Oct 22 14:45:30 2008
> > New Revision: 184161
> > URL: http://svn.freebsd.org/changeset/base/184161
> >
> > Log:
> >   Fix compiler error with missing/unneded ')'
> >
> > Modified:
> >   head/sys/i386/i386/identcpu.c
> >
> > Modified: head/sys/i386/i386/identcpu.c
> > =================================================================
> >============= --- head/sys/i386/i386/identcpu.c	Wed Oct 22
> > 10:12:21 2008	(r184160) +++ head/sys/i386/i386/identcpu.c	Wed Oct
> > 22 14:45:30 2008	(r184161) @@ -842,9 +842,9 @@ printcpuinfo(void)
> >  				cpu_feature &= ~CPUID_HTT;
> >
> >  			if (!tsc_is_invariant &&
> > -			    (strcmp(cpu_vendor, "AuthenticAMD") == 0 &&
> > -			    (amd_pminfo & AMDPM_TSC_INVARIANT) != 0 ||
> > -			    I386_CPU_FAMILY(cpu_id) >= 0x10))) {
> > +			    ((strcmp(cpu_vendor, "AuthenticAMD") == 0 &&
> > +			    (amd_pminfo & AMDPM_TSC_INVARIANT) != 0) ||
> > +			    I386_CPU_FAMILY(cpu_id) >= 0x10)) {
> >  				tsc_is_invariant = 1;
> >  				printf("\n  P-state invariant TSC");
> >  			}
>
> Taking apart commit message, I think you change is wrong
> semantically. Checking CPU_FAMILY without first checking vendor is
> meaningless.

Correct.  Please do not touch this part cause I am going to fix it and 
add more quirks.

Sorry for the breakage.

Jung-uk Kim