svn commit: r185237 - head/lib/libutil
Sean C. Farley
scf at FreeBSD.org
Tue Nov 25 09:41:35 PST 2008
On Mon, 24 Nov 2008, Dag-Erling Smørgrav wrote:
> Sean Farley <scf at FreeBSD.org> writes:
>> Log:
>> Fixed style issues with variable ordering and naming, spacing and
>> parentheses.
>>
>> Fixed alignment issue in gr_dup() in its assignment of gr_mem using a
>> struct to force alignment without performing alignment mathematics. This
>> was noticed recently with libutil was built with WARNS=6 on platform such
>> as sparc64.
>>
>> Added checks to gr_dup(), gr_equal() and gr_make() to prevent segfaults
>> when examining struct group's with the struct members pointing to NULL's.
>>
>> With fix of alignment issue, restore WARNS?=6.
>
> Good work, thank you!
You are welcome. Thank you too for the help on the alignment issue and
plethora of style questions. :)
Sean
--
scf at FreeBSD.org
More information about the svn-src-head
mailing list