svn commit: r184625 - in head: etc sys/dev/acpi_support

Ulrich Spoerlein uspoerlein at gmail.com
Tue Nov 4 11:27:55 PST 2008


On Tue, 04.11.2008 at 18:41:12 +0200, Nikolay Denev wrote:
> On 4 Nov, 2008, at 18:08 , Andrew Thompson wrote:
> > On Tue, Nov 04, 2008 at 11:52:50AM +0000, Rui Paulo wrote:
> >> Author: rpaulo
> >> Date: Tue Nov  4 11:52:50 2008
> >> New Revision: 184625
> >> URL: http://svn.freebsd.org/changeset/base/184625
> >>
> >> Log:
> >>  Add support for Asus A8Sr notebooks.
> >>
> >>  PR:		128553
> >>  Submitted by:	Eygene Ryabinkin <rea-fbsd at codelabs.ru>
> >>  Reviewed by:	philip
> >>  MFC after:	2 months
> >>
> >> Modified:
> >>  head/etc/devd.conf
> >>  head/sys/dev/acpi_support/acpi_asus.c
> >
> > We could almost do with a /etc/devd.conf.d/ directory to drop in
> > hardware specific event files.
> This is exactly what I was thinking yesterday,
> because the devd.conf seems to continue to grow.
> 
> Maybe use it only as a placeholder for includes, which
> can be located in /dev/devd/ or /etc/devd.conf.d/ ?
> 
> And probably the events can be separated further in different files,
> based on the event types i.e. device, ACPI , IFNET, ZFS

Ok, I'll throw in: Keep it all in one file! I like to have stuff rather
centralized where you can easily search and compare stuff. Otherwise
you'd have to look through a dozen of files under /etc/devd.conf.d

blech

Cheers,
Ulrich Spoerlein
-- 
It is better to remain silent and be thought a fool,
than to speak, and remove all doubt.


More information about the svn-src-head mailing list