svn commit: r351604 - head/sys/dev/ichsmb

Yuri Pankov yuripv at FreeBSD.org
Thu Aug 29 12:49:22 UTC 2019


Author: yuripv
Date: Thu Aug 29 12:49:21 2019
New Revision: 351604
URL: https://svnweb.freebsd.org/changeset/base/351604

Log:
  ichsmb: defer smbus attach until interrupts are available
  
  This fixes a "timed sleep before timers are working" panic seen
  while attaching jedec_dimm(4) instances too early in the boot.
  
  Submitted by:	ian
  Reviewed by:	hselasky
  Differential Revision:	https://reviews.freebsd.org/D21452

Modified:
  head/sys/dev/ichsmb/ichsmb.c

Modified: head/sys/dev/ichsmb/ichsmb.c
==============================================================================
--- head/sys/dev/ichsmb/ichsmb.c	Thu Aug 29 12:05:06 2019	(r351603)
+++ head/sys/dev/ichsmb/ichsmb.c	Thu Aug 29 12:49:21 2019	(r351604)
@@ -131,11 +131,8 @@ ichsmb_attach(device_t dev)
 		goto fail;
 	}
 
-	/* Attach "smbus" child */
-	if ((error = bus_generic_attach(dev)) != 0) {
-		device_printf(dev, "failed to attach child: %d\n", error);
-		goto fail;
-	}
+	/* Probe and attach the smbus when interrupts are available */
+	config_intrhook_oneshot((ich_func_t)bus_generic_attach, dev);
 
 	return (0);
 


More information about the svn-src-all mailing list