svn commit: r351459 - head/usr.bin/last

Conrad Meyer cem at freebsd.org
Sat Aug 24 18:50:30 UTC 2019


Hi Eugene,

This change introduced some style(9) violations.

On Sat, Aug 24, 2019 at 8:50 AM Eugene Grosbein <eugen at freebsd.org> wrote:
>
> Author: eugen
> Date: Sat Aug 24 15:50:13 2019
> New Revision: 351459
> URL: https://svnweb.freebsd.org/changeset/base/351459
> ...
> --- head/usr.bin/last/last.c    Sat Aug 24 15:38:07 2019        (r351458)
> +++ head/usr.bin/last/last.c    Sat Aug 24 15:50:13 2019        (r351459)
> ...
> @@ -158,7 +158,9 @@ main(int argc, char *argv[])
>         d_first = (*nl_langinfo(D_MD_ORDER) == 'd');
>
>         (void) setlocale(LC_CTYPE, "");
> -       utf8flag = (strcmp(nl_langinfo(CODESET), "UTF-8") == 0);
> +       p = nl_langinfo(CODESET);
> +       if (strcmp (p, "UTF-8") == 0 || strcmp (p, "US-ASCII") == 0)
> +               noctfix = 1;

There are extraneous spaces between strcmp and '('.

Best,
Conrad


More information about the svn-src-all mailing list