svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

[Warner Losh]

On Fri, Aug 23, 2019 at 10:10 AM Bjoern A. Zeeb <bz at freebsd.org> wrote:

> On 23 Aug 2019, at 15:53, Warner Losh wrote:
>
> > Sorry for top posting...
> >
> > I had planned this for next week, but I think give this insanity of
> > this
> > patch, we  should do it now: turn off -Werror for gcc 4.2.1
> >
> > https://reviews.freebsd.org/D21378
> >
> > has the review. There's no benefit to these head-scratcher changes
> > when we
> > can get the same benefit by ignoring gcc 4.2.1 errors as discussed on
> > arch at .
>
> That brings me to a different question: why does this build
> https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/lastBuild/ not fail
> despite rendering the warnings
>

There's a lot of -Wno-error and -Wno-error=XXX sprinkled in our build for
gcc 4.2.1 today, so we see the warnings but aren't stopped by them. My
changes take a big hammer and add a global -Wno-error to CFLAGS last to
make this the behavior on gcc 4.2.1 platforms.

Warner