svn commit: r351244 - head/sys/dev/usb/net

[Gleb Smirnoff]

  Stephen,

On Tue, Aug 20, 2019 at 01:06:43AM +0000, Stephen J. Kiernan wrote:
S> Author: stevek
S> Date: Tue Aug 20 01:06:43 2019
S> New Revision: 351244
S> URL: https://svnweb.freebsd.org/changeset/base/351244
S> 
S> Log:
S>   usb_ethernet.h includes a number of mii headers, but only does so in
S>   order to have struct mii_data available. However, it only really needs
S>   a forward declaration of struct mii_data for use in pointer form for
S>   the return type of a function prototype.
S>   
S>   Custom kernel configuration that have usb and fdt enabled, but no miibus,
S>   end up with compilation failures because miibus_if.h will not get
S>   generated.
S>   
S>   Due to the above, the following changes have been made to usb_ethernet.h:
S>    * remove the inclusion of mii headers
S>    * forward-declare struct mii_data
S>    * include net/ifq.h to satify the need for complete struct ifqueue

This is a header (and structure) that is on a kill list :) Polluting another
header moves us a bit backwards.

Can you please take a look at the attached patch? It substitutes it for mbufq,
as already done for many other drivers.

-- 
Gleb Smirnoff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ue_rxq-mbufq.diff
Type: text/x-diff
Size: 2717 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20190822/a9906a71/attachment.diff>