svn commit: r332216 - stable/11/sys/netinet

Michael Tuexen tuexen at FreeBSD.org
Sat Apr 7 20:00:59 UTC 2018


Author: tuexen
Date: Sat Apr  7 20:00:58 2018
New Revision: 332216
URL: https://svnweb.freebsd.org/changeset/base/332216

Log:
  MFC r324954:
  
  Fix a locking issue found by running AFL on the userland stack.
  Thanks to Felix Weinrank for reporting the issue.

Modified:
  stable/11/sys/netinet/sctp_input.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/netinet/sctp_input.c
==============================================================================
--- stable/11/sys/netinet/sctp_input.c	Sat Apr  7 19:59:40 2018	(r332215)
+++ stable/11/sys/netinet/sctp_input.c	Sat Apr  7 20:00:58 2018	(r332216)
@@ -4866,9 +4866,6 @@ process_control_chunks:
 				if ((stcb != NULL) && (stcb->asoc.total_output_queue_size)) {
 					;
 				} else {
-					if (stcb != NULL) {
-						SCTP_TCB_UNLOCK(stcb);
-					}
 					*offset = length;
 					if (stcb != NULL) {
 #if defined(__APPLE__) || defined(SCTP_SO_LOCK_TESTING)


More information about the svn-src-all mailing list