svn commit: r327954 - in head/sys: amd64/conf conf dev/acpica vm x86/acpica

[John Baldwin]

On Sunday, April 01, 2018 01:35:45 PM Ian Lepore wrote:
> On Sun, 2018-01-14 at 03:36 +0000, Jeff Roberson wrote:
> > Author: jeff
> > Date: Sun Jan 14 03:36:03 2018
> > New Revision: 327954
> > URL: https://svnweb.freebsd.org/changeset/base/327954
> > 
> > Log:
> >   Move VM_NUMA_ALLOC and DEVICE_NUMA under the single global config
> > option NUMA.
> >   
> >   Sponsored by:	Netflix, Dell/EMC Isilon
> >   Discussed with:	jhb
> 
> It turns out this breaks building powerpc lint kernels. It shakes out
> like this... makeLINT.mk copies sys/conf/NOTES into the generated LINT
> config (I guess on the theory that things documented in NOTES are
> supported by all arches). So option NUMA is present on powerpc, but the
> powerpc vmparam.h doesn't define VM_LEVEL_0_ORDER so the build fails.
> (Mips also doesn't define that, but it has no lint kernel build at all
> right now.)
> 
> It could be fixed in vm_domainset.c with:
> 
> -#ifdef NUMA
> +#if defined(NUMA) && defined(VM_LEVEL_0_ORDER)
> 
> but there may be some better way to fix it, I don't know that much
> about this stuff.

Maybe add 'nooption NUMA' to sys/powerpc/conf/NOTES?  (It has several
nooption and nodevice lines already)  If it affects more than powerpc
then I wouldn't do that, but if it's only powerpc then I think patching
powerpc/conf/NOTES is most consistent with how this has been handled to
date.

-- 
John Baldwin