svn commit: r323365 - in head: cddl/lib/libzpool gnu/usr.bin/binutils/libbfd usr.bin/svn/lib/libsvn_client

[Konstantin Belousov]

On Sat, Sep 09, 2017 at 12:56:20PM -0700, Ngie Cooper (yaneurabeya) wrote:
> 
> > On Sep 9, 2017, at 11:35, Konstantin Belousov <kostikbel at gmail.com> wrote:
> > 
> > On Sat, Sep 09, 2017 at 01:18:33PM +0000, Jonathan Anderson wrote:
> >> Author: jonathan
> >> Date: Sat Sep  9 13:18:32 2017
> >> New Revision: 323365
> >> URL: https://svnweb.freebsd.org/changeset/base/323365
> >> 
> >> Log:
> >>  Remove redundant source and object files.
> > 
> >> Modified: head/gnu/usr.bin/binutils/libbfd/Makefile.amd64
> >> ==============================================================================
> >> --- head/gnu/usr.bin/binutils/libbfd/Makefile.amd64	Sat Sep  9 12:50:12 2017	(r323364)
> >> +++ head/gnu/usr.bin/binutils/libbfd/Makefile.amd64	Sat Sep  9 13:18:32 2017	(r323365)
> >> @@ -9,7 +9,6 @@ DEFAULT_VECTOR=	bfd_elf64_x86_64_freebsd_vec
> >> 
> >> SRCS+=	elf64-x86-64.c \
> >> 	efi-app-x86_64.c \
> >> -	efi-app-ia32.c \
> >> 	elf64.c \
> >> 	elf64-gen.c \
> >> 	elf64-target.h \
> > Why did you claimed that x86 efi binfmt is  redundant ?
> 
> 	It???s redundant because of how the Makefile gets .include???d (amd64 requires i386???s Makefile).
> Cheers,
> -Ngie
> 
> $ grep -r efi-app gnu/usr.bin/binutils/libbfd/
> gnu/usr.bin/binutils/libbfd/Makefile.amd64:     efi-app-x86_64.c \
> gnu/usr.bin/binutils/libbfd/Makefile.amd64:     efi-app-ia32.c \
> gnu/usr.bin/binutils/libbfd/Makefile.i386:      efi-app-ia32.c \
> $ grep include gnu/usr.bin/binutils/libbfd/Makefile.amd64
> .include "${.CURDIR}/Makefile.i386???

Then, why peigen.c was left in the SRCS ?