svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf

Alexey Dokuchaev danfe at FreeBSD.org
Fri Sep 1 16:50:37 UTC 2017


On Fri, Sep 01, 2017 at 11:23:56AM -0500, Josh Paetzel wrote:
> Yeah, the commit message is horrible.  I apologize.

I'm afraid this is not enough, esp. considering that this issue (utterly
bad commit messages) was recently brought up on developers@ once again.

Please revert and recommit with proper, elaborate, useful commit log.

> The phabricator is a little better but you have to read and parse the
> whole thing.
> 
> Then end result of this change is you can kldload ipsec AND tcpmd5,
> however ipsec support won't be in GENERIC.

Perhaps it should also explain why IPSEC_SUPPORT option is needed, as
well (e.g. if it does not cost anything, why not just optimize it away;
if it does imply something more, it should be explained and reflected
properly in the log).

./danfe


More information about the svn-src-all mailing list