svn commit: r325378 - head/sys/dev/ipmi

Warner Losh imp at bsdimp.com
Sat Nov 4 05:53:40 UTC 2017


On Fri, Nov 3, 2017 at 11:29 PM, Xin Li <delphij at delphij.net> wrote:

>
>
> On 11/3/17 20:01, Warner Losh wrote:
> > Author: imp
> > Date: Sat Nov  4 03:01:58 2017
> > New Revision: 325378
> > URL: https://svnweb.freebsd.org/changeset/base/325378
> >
> > Log:
> >   Make the startup timeout 0 seconds by default rathern than 420s.  This
> >   makes the default fail safe when watchdogd is disabled (which is also
> >   the default).
>
> I'm not sure if this is good: what if watchdogd is enabled, but the
> system get stuck before watchdogd starts?
>

Correct. This feature has to be opt-in on top of watchdogd. If you don't
add-in this feature, you won't have this new protection. You have to set
hw.ipmi.wd_startup_countdown to activate it.

More complicated logic may be possible, but the ipmi driver has no clue if
watchdogd is enabled, so I'm not sure I see a path forward to automatically
doing the right thing with sensible defaults. Have I overlooked something?

Warner


More information about the svn-src-all mailing list