svn commit: r302529 - head/sys/dev/ntb

Alexander Motin mav at FreeBSD.org
Sun Jul 10 19:15:31 UTC 2016


Author: mav
Date: Sun Jul 10 19:15:29 2016
New Revision: 302529
URL: https://svnweb.freebsd.org/changeset/base/302529

Log:
  Remove callout_reset(link_work) from ntb_transport_attach().
  
  At that point link is quite likely not established yet, so messing with
  scratch registers is premature there.  Original commit message mentioned
  code diff reduction from Linux, but this line is not present in Linux now.

Modified:
  head/sys/dev/ntb/ntb_transport.c

Modified: head/sys/dev/ntb/ntb_transport.c
==============================================================================
--- head/sys/dev/ntb/ntb_transport.c	Sun Jul 10 18:28:15 2016	(r302528)
+++ head/sys/dev/ntb/ntb_transport.c	Sun Jul 10 19:15:29 2016	(r302529)
@@ -394,7 +394,6 @@ ntb_transport_attach(device_t dev)
 	nt->link_is_up = false;
 	NTB_LINK_ENABLE(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);
 
-	callout_reset(&nt->link_work, 0, ntb_transport_link_work, nt);
 	if (enable_xeon_watchdog != 0)
 		callout_reset(&nt->link_watchdog, 0, xeon_link_watchdog_hb, nt);
 


More information about the svn-src-all mailing list