svn commit: r294362 - in head/sys: dev/uart kern sys

Adrian Chadd adrian.chadd at gmail.com
Wed Jan 20 02:38:55 UTC 2016


On 19 January 2016 at 18:36, John Baldwin <jhb at freebsd.org> wrote:

[snip]

>
> The code in ttydev_leave() is:
>
>         /* Drain any output. */
>         MPASS((tp->t_flags & TF_STOPPED) == 0);
>         if (!tty_gone(tp))
>                 tty_drain(tp, 1);
>
> Nothing in tty_drain() sets TF_GONE yet, so this seems to be a guaranteed
> panic.
>
> Various other places also call tty_drain() when then tty is not "gone"
> including the ioctl's backing tcsetattr().

ok, so should we back the patch out until it's addressed?


-a


More information about the svn-src-all mailing list