svn commit: r293776 - stable/10/usr.sbin/fstyp

[Warner Losh]

> On Jan 13, 2016, at 9:26 AM, Allan Jude <allanjude at FreeBSD.org> wrote:
> 
> On 2016-01-13 08:18, Slawa Olhovchenkov wrote:
>> On Tue, Jan 12, 2016 at 04:38:09PM +0000, Allan Jude wrote:
>> 
>>> Author: allanjude
>>> Date: Tue Jan 12 16:38:09 2016
>>> New Revision: 293776
>>> URL: https://svnweb.freebsd.org/changeset/base/293776
>>> 
>>> Log:
>>>  MFC: r284589
>>>    Add the ability to detect ZFS and GELI encrypted file systems to fstyp(8)
>>> 
>>>  MFC: r284644
>>>    Fix GCC Warnings
>>> 
>>>  MFC: r284728
>>>    Only build ZFS support in absense of WITHOUT_ZFS
>> 
>> What purpose for switch off ZFS support in case WITHOUT_ZFS?
>> 
> 
> If the user builds FreeBSD WITHOUT_CDDL or WITHOUT_ZFS, then they are
> requesting that we not build the ZFS code, so building it anyway would
> be against their wishes. The most likely reason they would request this
> is for license reasons.

For x86, that may be true. For arm and mips platforms, ZFS is too much of a
memory pig-dog to run on much of the kit we run on in that space. Turning it
off is part of removing the type 2 muda from the system.

In any event, the double negative is true. Don’t build ZFS when its absence has
been requested with WITHOUT_ZFS is correct.

Warner

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20160113/eaa42cb1/attachment.sig>