svn commit: r292788 - in head/sys: geom/part sys

[Ravi Pokala]

-----Original Message-----


From: <owner-src-committers at freebsd.org> on behalf of "Andrey V. Elsukov" <bu7cher at yandex.ru>
Date: 2016-01-11, Monday at 00:36
To: Ravi Pokala <rpokala at mac.com>, Allan Jude <allanjude at FreeBSD.org>, <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
Subject: Re: svn commit: r292788 - in head/sys: geom/part sys

>On 11.01.16 07:54, Ravi Pokala wrote:
>> In that review, there was discussion about the sorting of aliases in
>(enum g_part_alias). It was originally thought that the aliases needed
>to be sorted, due to binary searching in g_part_alias_name(). It turned
>out that g_part_alias_name() did a linear search, so the list didn't
>strictly need to be sorted. But, there was talk of potentially switching
>to a binary search later, so Allan went with the sorted version.
>
>Hi,
>
>no, my note was relate to the following possible problem:
>you have some stable/10 and some geom_part_panasas module installed from
>the ports in the /boot/modules. When you rebuild the kernel after
>merging r292788 your module will use old values of g_part_alias and thus
>it will get not the same aliases. You will need rebuild your module to
>fix this.

Right, I explained your concerns later down in the email. However, I don't think they're applicable, because it doesn’t look like anything is actually using the enum outside of GEOM_PART driver.

Thanks,

Ravi (rpokala@)