svn commit: r290499 - head/usr.bin/localedef

Baptiste Daroussin bapt at FreeBSD.org
Sat Nov 7 16:29:18 UTC 2015


On Sat, Nov 07, 2015 at 05:26:17PM +0100, Joerg Sonnenberger wrote:
> On Sat, Nov 07, 2015 at 04:22:29PM +0000, Baptiste Daroussin wrote:
> > Author: bapt
> > Date: Sat Nov  7 16:22:29 2015
> > New Revision: 290499
> > URL: https://svnweb.freebsd.org/changeset/base/290499
> > 
> > Log:
> >   Workaround an issue on i386 to unbreak the build until the real issue is tracked
> >   down
> > 
> > Modified:
> >   head/usr.bin/localedef/collate.c
> > 
> > Modified: head/usr.bin/localedef/collate.c
> > ==============================================================================
> > --- head/usr.bin/localedef/collate.c	Sat Nov  7 15:03:45 2015	(r290498)
> > +++ head/usr.bin/localedef/collate.c	Sat Nov  7 16:22:29 2015	(r290499)
> > @@ -1255,7 +1255,8 @@ dump_collate(void)
> >  	 * Large (> UCHAR_MAX) character priorities
> >  	 */
> >  	RB_NUMNODES(collchar_t, collchars, &collchars, n);
> > -	large = calloc(sizeof (collate_large_t) * n, 1);
> > +	large = malloc(sizeof (collate_large_t) * n);
> > +	memset(large, 0, sizeof (collate_large_t) * n);
> >  	if (large == NULL) {
> >  		fprintf(stderr, "out of memory");
> >  		return;
> 
> Why was this not calloc(sizeof(), n) in first place?!

I tried not to diverge too much from upstream (Illumos here), that is the
reason. but the same issue happens with calloc(sizeof(), n)

Issue being: <jemalloc>: jemalloc_arena.c:353: Failed assertion: "p[i] == 0"

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20151107/73deb3d8/attachment.bin>


More information about the svn-src-all mailing list