svn commit: r282985 - in head/sys: arm/annapurna arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm

[Garrett Cooper]

> On May 18, 2015, at 07:04, Ian Lepore <ian at freebsd.org> wrote:
> 
>> On Mon, 2015-05-18 at 10:14 +0200, Mathieu Arnold wrote:
>> +--On 18 mai 2015 00:21:43 -0700 Eitan Adler <eadler at freebsd.org> wrote:
>> | On 17 May 2015 at 08:46, Ian Lepore <ian at freebsd.org> wrote:
>> |> On Sat, 2015-05-16 at 21:04 -0700, Garrett Cooper wrote:
>> |>> > On May 16, 2015, at 18:45, Adrian Chadd <adrian at freebsd.org> wrote:
>> |>> > 
>> |>> > Did you commit files with DOS newlines in them? :)
>> |>> > 
>> |>> > tsk tsk tsk tsk tsk. I think should fix that..
>> |>> 
>> |>> Better yet it should probably be disabled in svn...
>> |>> 
>> |> 
>> |> Or flagged by some filter as a diff is uploaded to phabricator, since
>> |> the web display obscures whitespace.
>> | 
>> | This is possible.  Would blocking all diffs that match /\r\n$/ work?
>> 
>> That would crap up all patches that match that, which is a bad idea.
> 
> Why would that be a bad idea?  Do we have files in the system that
> legitimately end with MSDOS line endings that need to be preserved as
> such?
> 
> I'm not sure blocking is the right thing anyway, it would be better if
> it was like a warning dialog..."The diff you just uploaded contains DOS
> line endings, continue?"

There are some files in contrib/ with CRLF endings iirc...
Thanks!