svn commit: r281643 - head/sys/net

[Peter Wemm]

On Sunday, May 03, 2015 09:31:01 PM Peter Wemm wrote:
> On Friday, April 17, 2015 06:39:16 AM Gleb Smirnoff wrote:
> > Author: glebius
> > Date: Fri Apr 17 06:39:15 2015
> > New Revision: 281643
> > URL: https://svnweb.freebsd.org/changeset/base/281643
> > 
> > Log:
> >   Bring in if_types.h from projects/ifnet, where types are
> >   defined in enum.
> > 
> > Modified:
> >   head/sys/net/if_types.h
> 
> I'm sorry, but this breaks the freebsd.org cluster.
> 
> 281642 works
> 281643 fails
> head with 281643 reverted works
> 
> IPv6 doesn't work on systems with pf, carp and multiple interfaces.  I have
> nothing more specific than that.

The kernel is smaller with the enums:
          text     data       bss           dec             hex  
11438123   730686   2998048   15166857   0xe76d89  
11437787   730686   2998048   15166521   0xe76c39

The first is with the #defines, the second is enums.  The enums caused 336 bytes 
less code to be generated, so presumably the enums enabled some "optimization" 
that wasn't expected.

-- 
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com; KI6FJV
UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20150503/d99b10a3/attachment.sig>