svn commit: r282314 - in head: include lib/libc/stdlib

Pedro Giffuni pfg at FreeBSD.org
Fri May 1 19:09:14 UTC 2015


Hi;

Sorry that I missed the review ...

On 05/01/15 13:32, Baptiste Daroussin wrote:
> ...
> Modified: head/include/stdlib.h
> ==============================================================================
> --- head/include/stdlib.h	Fri May  1 18:07:18 2015	(r282313)
> +++ head/include/stdlib.h	Fri May  1 18:32:16 2015	(r282314)
> @@ -111,6 +111,9 @@ long double
>   	 strtold(const char * __restrict, char ** __restrict);
>   unsigned long
>   	 strtoul(const char * __restrict, char ** __restrict, int);
> +#ifdef __BSD_VISIBLE
> +void	*reallocarray(void *, size_t, size_t);
> +#endif
>   int	 system(const char *);
>   int	 wctomb(char *, wchar_t);
>   size_t	 wcstombs(char * __restrict, const wchar_t * __restrict, size_t);

Please move it to the _BSD_VISIBLE section, along with reallocf.
Also please add the __alloc_size attributes[1] while there.

For the record, I dislike adding this non-standard function, especially
considering that NetBSD added yet another variant, but I guess it
helps importing new stuff from OpenBSD.

Pedro.

[1] It should be
__result_use_check __alloc_size(2) __alloc_size(3)



More information about the svn-src-all mailing list