svn commit: r282257 - in head: lib/libnv sys/kern sys/sys

[Bryan Drewery]

On 4/29/2015 5:57 PM, Mariusz Zaborski wrote:
> Author: oshogbo
> Date: Wed Apr 29 22:57:04 2015
> New Revision: 282257
> URL: https://svnweb.freebsd.org/changeset/base/282257
> 
> Log:
>   Remove the nvlist_.*[fv] functions.
>   
>   Those functions are problematic, because there is no way to report
>   memory allocation problems without complicating the API, so we can
>   either abort or potentially return invalid results. None of which is
>   acceptable.
>   
>   In most cases the caller knows the size of the name, so he can allocate
>   buffer on the stack and use snprintf(3) to prepare the name.
>   
>   After some discussion the conclusion is to removed those functions,
>   which also simplifies the API.
>   
>   Discussed with: pjd, rstone
>   Approved by:	pjd (mentor)
> 
> Modified:
>   head/lib/libnv/Makefile

This breaks the ABI of libnv.so.0.

You should either bump the SHLIB_MAJOR or consider making this a
PRIVATELIB so it is not in the public /lib but in the private
/usr/lib/private or use symbol versioning.

Being in /lib we must maintain ABI compatibility among the same shlib
version.

Bumping the SHLIB_MAJOR or moving to PRIVATELIB will require adding the
libnv.so.0 to the ObsoleteFiles.inc OLD_FILES list.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20150430/1f61c9c6/attachment.sig>