svn commit: r281798 - head/lib/libc/iconv

Pedro F. Giffuni pfg at FreeBSD.org
Mon Apr 20 22:09:51 UTC 2015


Author: pfg
Date: Mon Apr 20 22:09:50 2015
New Revision: 281798
URL: https://svnweb.freebsd.org/changeset/base/281798

Log:
  Fix improbable memory leak in _citrus_prop_read_str().
  
  Found by:	Clang Static Analyzer

Modified:
  head/lib/libc/iconv/citrus_prop.c

Modified: head/lib/libc/iconv/citrus_prop.c
==============================================================================
--- head/lib/libc/iconv/citrus_prop.c	Mon Apr 20 22:08:11 2015	(r281797)
+++ head/lib/libc/iconv/citrus_prop.c	Mon Apr 20 22:09:50 2015	(r281798)
@@ -293,8 +293,10 @@ done:
 		}
 		_memstream_ungetc(ms, ch);
 		errnum = _citrus_prop_read_character_common(ms, &ch);
-		if (errnum != 0)
+		if (errnum != 0) {
+			free(s);
 			return (errnum);
+		}
 		s[n] = ch;
 		++n, --m;
 	}


More information about the svn-src-all mailing list